Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Domain accessible in NLU Pipeline #4285

Closed
4 tasks
dakshvar22 opened this issue Aug 20, 2019 · 2 comments
Closed
4 tasks

Make Domain accessible in NLU Pipeline #4285

dakshvar22 opened this issue Aug 20, 2019 · 2 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@dakshvar22
Copy link
Contributor

Description of Problem:
Currently the domain.yml file is read and made accessible only in the Core pipeline. As we include more features into the complete stack, there may be some which do not follow the clear boundary between NLU and Core. One such example feature is Supervised Response Selector. The particular part where the domain file is needed is described in this comment .
There may be more such use cases where this might be necessary.

Overview of the Solution:

  • We'll need to move out domain.py outside of rasa.core since it would be shared between NLU and Core.
  • For the training phase, similar to how domain is loaded inside _train_core_with_validated_data() function we can load it inside train_nlu_with_validated_data() and pass it to rasa.nlu.train() function.
  • Both Trainer and TrainingData could potentially need access to the Domain instance.
  • During inference, individual components may need to use the domain data for processing the message.

Blockers (if relevant):
Any ideas?

Definition of Done:

  • Tests are added
  • Feature described the docs
  • Feature mentioned in the changlog
  • Compatibility test for existing features
@dakshvar22 dakshvar22 added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Aug 20, 2019
@msamogh
Copy link
Contributor

msamogh commented Aug 20, 2019

You'd also need to ensure the fingerprints don't step on each other, because right now, the whole domain just gets one single fingerprint.

@dakshvar22 dakshvar22 changed the title Domain accessible in NLU Pipeline Make Domain accessible in NLU Pipeline Aug 26, 2019
@dakshvar22
Copy link
Contributor Author

Not pursuing this for now, as the primary use case was solved in a different way #4233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

2 participants