-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding docker image creation for nightly runs #12357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchariGr
force-pushed
the
nightly_docker
branch
2 times, most recently
from
May 4, 2023 14:35
6510a94
to
7cba5dd
Compare
sanchariGr
force-pushed
the
nightly_docker
branch
3 times, most recently
from
May 4, 2023 16:52
7b0fec3
to
ed721c1
Compare
sanchariGr
force-pushed
the
nightly_docker
branch
2 times, most recently
from
May 5, 2023 16:37
9e65ac6
to
4370bde
Compare
sanchariGr
requested review from
rasa-jmac and
ancalita
and removed request for
ancalita and
rasa-jmac
May 5, 2023 16:58
sanchariGr
commented
May 5, 2023
ancalita
reviewed
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯 Only had some clarifying questions.
sanchariGr
force-pushed
the
nightly_docker
branch
from
May 10, 2023 13:52
e989a85
to
5eb810c
Compare
sanchariGr
requested review from
rasa-aadlv and
ancalita
and removed request for
a team
May 10, 2023 14:18
ancalita
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ancalita this worked https://console.cloud.google.com/artifacts/docker/rasa-ci-cd/europe-west3/rasa/rasa?authuser=1&project=rasa-ci-cd
Tested in a separate branch https://github.com/RasaHQ/rasa/actions/runs/4937897873.