Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker image creation for nightly runs #12357

Merged
merged 11 commits into from
May 11, 2023
Merged

Adding docker image creation for nightly runs #12357

merged 11 commits into from
May 11, 2023

Conversation

sanchariGr
Copy link
Collaborator

@sanchariGr sanchariGr commented May 4, 2023

@sanchariGr sanchariGr force-pushed the nightly_docker branch 2 times, most recently from 6510a94 to 7cba5dd Compare May 4, 2023 14:35
@sanchariGr sanchariGr force-pushed the nightly_docker branch 3 times, most recently from 7b0fec3 to ed721c1 Compare May 4, 2023 16:52
@sanchariGr sanchariGr force-pushed the nightly_docker branch 2 times, most recently from 9e65ac6 to 4370bde Compare May 5, 2023 16:37
@sanchariGr sanchariGr requested review from rasa-jmac and ancalita and removed request for ancalita and rasa-jmac May 5, 2023 16:58
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯 Only had some clarifying questions.

.github/workflows/continous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/nightly_release.yml Outdated Show resolved Hide resolved
.github/workflows/nightly_release.yml Show resolved Hide resolved
.github/workflows/nightly_release.yml Outdated Show resolved Hide resolved
.github/workflows/nightly_release.yml Outdated Show resolved Hide resolved
.github/workflows/nightly_release.yml Outdated Show resolved Hide resolved
@sanchariGr sanchariGr marked this pull request as ready for review May 10, 2023 14:18
@sanchariGr sanchariGr requested a review from a team as a code owner May 10, 2023 14:18
@sanchariGr sanchariGr requested review from rasa-aadlv and ancalita and removed request for a team May 10, 2023 14:18
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing 🎉

@sanchariGr sanchariGr merged commit 0b25de7 into main May 11, 2023
@sanchariGr sanchariGr deleted the nightly_docker branch May 11, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants