From 19903eae822da23209c74c185191b8a97b015d04 Mon Sep 17 00:00:00 2001 From: ricwo Date: Fri, 5 Oct 2018 09:35:09 +0200 Subject: [PATCH 1/2] #1442 make max_training_processes apply globally --- CHANGELOG.rst | 4 ++++ rasa_nlu/data_router.py | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 89909c09508..79699dba6e0 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -20,6 +20,10 @@ Removed Fixed ----- +- ``rasa_nlu.server`` allowed more than ``max_training_processes`` + to be trained if they belong to different projects. + ``max_training_processes`` is now a global parameter, regardless of what + project the training process belongs to. [0.13.6] - 2018-10-04 ^^^^^^^^^^^^^^^^^^^^^ diff --git a/rasa_nlu/data_router.py b/rasa_nlu/data_router.py index 826959873eb..c57cd0e9992 100644 --- a/rasa_nlu/data_router.py +++ b/rasa_nlu/data_router.py @@ -328,11 +328,11 @@ def start_train_process(self, if not project: raise InvalidProjectError("Missing project name to train") + if self._training_processes <= self._current_training_processes: + raise MaxTrainingError + if project in self.project_store: - if self._training_processes <= self._current_training_processes: - raise MaxTrainingError - else: - self.project_store[project].status = 1 + self.project_store[project].status = 1 elif project not in self.project_store: self.project_store[project] = Project( self.component_builder, project, From a418fb9e75115c445690ee4febaedfb4ea442937 Mon Sep 17 00:00:00 2001 From: ricwo Date: Fri, 5 Oct 2018 12:23:56 +0200 Subject: [PATCH 2/2] #1442 travis did not report status -> rebuild