Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Guide updates #3818

Merged
merged 6 commits into from Jul 4, 2019

Conversation

Projects
None yet
3 participants
@rgstephens
Copy link
Contributor

commented Jun 18, 2019

Proposed changes:
Misc updates including #3793

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

rgstephens added some commits Jun 18, 2019

@akelad

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

Thanks a lot for submitting this PR 🙏 we'll give it a review as soon as possible

@tmbo tmbo requested a review from erohmensing Jun 25, 2019

@erohmensing
Copy link
Member

left a comment

Looks great, thank you for adding this information! Just a couple small changes and we'll be good to merge. 👍

Show resolved Hide resolved docs/migration-guide.rst Outdated
Show resolved Hide resolved docs/migration-guide.rst Outdated
@erohmensing

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

@rgstephens would you update this? Would love to get this info into the guide and get your first contribution in!

rgstephens and others added some commits Jul 2, 2019

Update docs/migration-guide.rst
Co-Authored-By: Ella Rohm-Ensing <erohmensing@gmail.com>
Update docs/migration-guide.rst
Co-Authored-By: Ella Rohm-Ensing <erohmensing@gmail.com>
@rgstephens

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Done. Not my first PR ;)

@erohmensing erohmensing self-requested a review Jul 3, 2019

@erohmensing
Copy link
Member

left a comment

Awesome! Thanks for contributing!

@erohmensing erohmensing merged commit ce43f1a into RasaHQ:master Jul 4, 2019

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.007%) to 81.0%
Details
Travis CI - Pull Request Build Passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.