977: Ignore class member validation errors in sentry #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiswells97
reviewed
Oct 27, 2025
|
|
||
| def handle_class_teacher_error(exception, class_teacher, teacher, response) | ||
| Sentry.capture_exception(exception) | ||
| Sentry.capture_exception(exception) unless exception.is_a?(ActiveRecord::RecordInvalid) |
Contributor
There was a problem hiding this comment.
Could there be any other reason for the record to be invalid apart from the cases we want to exclude?
Contributor
Author
There was a problem hiding this comment.
I've gone back and forth a bit with this one, since I think it's probably the case that none of the validations should be logged to sentry and RecordInvalid is indicative of validations...but if we were to add any validations further down the line that are exceptions to this rule (and we need them to be logged) we'd be suppressing them...so I think safest is to just to check explicitly for this error, and add a test giving us a bit of regression coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/977
What's changed?
Ensures validation errors aren't raised for ClassMembers in Sentry, this is especially important for the importer where a re-import would trigger potentially hundreds of these
Steps to perform after deploying to production
N/A