Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few suggestions #2

Merged
merged 5 commits into from Nov 12, 2019

Conversation

@junegunn
Copy link
Contributor

junegunn commented Nov 12, 2019

Hi, this seems like a great idea, thanks for sharing.

I'd like to make a few suggestions. Feel free to cherry-pick or ignore 馃槂

junegunn added 5 commits Nov 12, 2019
Also allow users to pass custom preview options to the script

    ./chrome-tab-activate --preview-window up
    ./chrome-tab-activate --no-preview
@Rasukarusan

This comment has been minimized.

Copy link
Owner

Rasukarusan commented Nov 12, 2019

Oh! Thanks your suggestions and pull requests!馃槏
It seems more smart and cool. I didn't know that I could write like this --delimiter $'\t' --with-nth 4 --preview 'echo {3}'. And the preview of url is good.

Thanks and I love fzf. 鈽锔

@Rasukarusan Rasukarusan merged commit 34d1ffa into Rasukarusan:master Nov 12, 2019
@junegunn junegunn deleted the junegunn:suggestions branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.