Permalink
Commits on Aug 22, 2013
  1. Fix localization key prefix.

    The T in "WoT" is not capitalized in this case.
    Thynix committed Aug 22, 2013
  2. Refactor Toadlet registration for readability.

    This moves repeated calls into methods and removes named instance
    variables where there are not needed.
    Thynix committed Aug 22, 2013
Commits on Aug 21, 2013
  1. Build0013. Changelog in tag.

    xor-freenet committed Aug 21, 2013
Commits on Aug 20, 2013
  1. Resolve FIXME and improve the affected test:

    - Fix the typo in its name
    - Notice the "@Ignore" keyword on the local class is JUnit4, thats why I had to upgrade.
    - Notice that the local class looks like bloat at first but it prevents copypasta of its update() function all around the test. I want to start using all features of the Java language to full extent :)
    - Also document where the sub tests end to improve readability
    - This commit fixes bug 0005987
    xor-freenet committed Aug 20, 2013
  2. Add TODO

    xor-freenet committed Aug 20, 2013
  3. Use JUnit4:

    - Needed for the following commit.
    - It it supposed to be backwards compatible with JUnit 3. And in fact all tests pass for me.
    - It has been around for 7 years.
    xor-freenet committed Aug 20, 2013
  4. Resolve FIXME

    xor-freenet committed Aug 20, 2013
  5. Fix bug 0004723:

    - Set maxArchiveLevels to 0 on all fetches as toad suggested.
    xor-freenet committed Aug 20, 2013
Commits on Aug 15, 2013
  1. Add assert().

    xor-freenet committed Aug 15, 2013
  2. Remove useless "synchronized" function attribute:

    - All callers of this function do synchronize on the WebOfTrust
    - The callers are even required to synchronize on it, so this commit also documents that.
    xor-freenet committed Aug 15, 2013
  3. Document synchronization requirements.

    - I have checked the existing callers of this function and they meet the requirements.
    xor-freenet committed Aug 15, 2013
  4. Get rid of deprecated function by inlineing it into its only caller:

    - The code which I did not inline is already present at a higher nesting level in the function.
    xor-freenet committed Aug 15, 2013
Commits on Aug 14, 2013
  1. Add proper synchronization of IdentityFetcher/IntroductionPuzzleStore…

    … to deleteDuplicateObjects()
    xor-freenet committed Aug 14, 2013
  2. Add proper synchronization of IdentityFetcher/IntroductionPuzzleStore…

    … to checkForDatabaseLeaks()
    xor-freenet committed Aug 14, 2013
  3. Document (acceptable) lack of IntroductionPuzzleStore/IdentityFetcher…

    … synchronization in upgradeDB():
    
    - This is to ensure that nobody moves the function to a place where it would be needed.
    xor-freenet committed Aug 14, 2013
  4. Document locking order of class IdentityFetcher:

    - We always lock the WOT first because its objects (Identity, Trust, Score) are the base objects for everything else.
    - The order between IntroductionPuzzleStore and IdentityFetcher is defined by the current code in class IntroductionServer. Its onSuccess() first locks the puzzlestore and then uses XMLTransformer.importIntroduction() which locks the IdentityFetcher
    - The database can always be locked last when we actually start modifying stuff.
    xor-freenet committed Aug 14, 2013
Commits on Aug 11, 2013
  1. Don't use the deprecated deleteIdentity() in the FCP interface:

    - It is very unlikely that a RuntimeException happens there. If it does, it would be acceptable for the identity not to be deleted there.
    - Also, upgrade the TODO related to the modified code to a FIXME
    xor-freenet committed Aug 11, 2013
Commits on Aug 10, 2013
  1. Add Debugging.txt to developer documentation:

    - It explains which functions should be used periodically by developers to check for bugs. Those are functions which cannot be run during normal WOT operation. An example is checkForDatabaseLeaks() - it deletes everything in the database so we cannot use it as an automatic self test.
    xor-freenet committed Aug 10, 2013
  2. Implement function for searching for database object leaks:

    - This implements bug 0005861
    xor-freenet committed Aug 10, 2013
  3. Documentation.

    xor-freenet committed Aug 10, 2013
  4. Documentation.

    xor-freenet committed Aug 10, 2013
Commits on Aug 9, 2013
  1. Clone Date objects to make sure that we don't re-use db4o-stored obje…

    …cts. Arguably Date is a db4o-native class so its not necessary but I'd like to have it this way as the Date stuff is probably less well-tested than the other native classes such as String (which we don't clone).
    xor-freenet committed Aug 9, 2013
Commits on Aug 7, 2013
  1. Russian translation.

    wannamore committed with toad Aug 7, 2013