Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for raw blob responses #18

Merged
merged 1 commit into from Dec 19, 2012
Merged

Conversation

danburkert
Copy link
Contributor

To receive a blob in raw format from, add

 {:accept "application/vnd.github.beta.raw"}

to the data/blob options map.

If 400, 422, 404, 204, or 500, return the original response with the body parsed
as json. Otherwise, parse and return the body."
If 400, 422, 404, 204, or 500, return the original response with the body parsed
as json. Otherwise, parse and return the body if json, or return the body if raw."
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but do you think you could indent this docstring back the way it was? I've got nothing against this style, just that it isn't consistent with the rest of the library.

To receive a blob in raw format from, add
    {:accept "application/vnd.github.beta.raw"}
to the data/blob options map.
@danburkert
Copy link
Contributor Author

Fixed the comment indent issue

@Raynes
Copy link
Owner

Raynes commented Dec 19, 2012

Excellent! Thanks!

Raynes added a commit that referenced this pull request Dec 19, 2012
Add support for raw blob responses
@Raynes Raynes merged commit 05876e5 into Raynes:master Dec 19, 2012
@danburkert danburkert deleted the raw-blob branch December 19, 2012 04:20
@danburkert
Copy link
Contributor Author

Glad to do it, thanks for being so prompt.

@Raynes
Copy link
Owner

Raynes commented Dec 19, 2012

Don't get used to it, I'm usually lazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants