Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use :oauth-token instead of :auth #54

Merged
merged 1 commit into from Aug 28, 2014
Merged

use :oauth-token instead of :auth #54

merged 1 commit into from Aug 28, 2014

Conversation

etoews
Copy link
Contributor

@etoews etoews commented Aug 28, 2014

The way the README is currently written made it sound like you just put :oauth-token in to the options map in addition to :auth. When you add it, the header that gets put into the request is

>> Authorization: Basic asfdhjkfshjdfsdhjsfhdja897243879487943=

So it's still trying to do basic auth with the username/password. You really need to use :oauth-token instead of :auth. When you replace it, the header that gets put into the request is

>> Authorization: token 87934589534980dgsflnjkldfgsfgsfd

For me this was a "Personal access token" created from the Applications Settings page.

The way the README is currently written made it sound like you just put :oauth-token in to the options map _in addition to_ :auth. When you add it, the header that gets put into the request is

    >> Authorization: Basic asfdhjkfshjdfsdhjsfhdja897243879487943=

So it's still trying to do basic auth with the username/password. You really need to use :oauth-token _instead_ of :auth. When you replace it, the header that gets put into the request is

    >> Authorization: token 87934589534980dgsflnjkldfgsfgsfd

For me this was a "Personal access token" created from the [Applications Settings](https://github.com/settings/applications) page.
Raynes added a commit that referenced this pull request Aug 28, 2014
use :oauth-token instead of :auth
@Raynes Raynes merged commit 2995806 into Raynes:master Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants