Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix bug in Opera 12 and FF 10 with document.createTreeWalker #40

Open
termi opened this Issue Jan 27, 2012 · 4 comments

Comments

Projects
None yet
2 participants
Collaborator

termi commented Jan 27, 2012

http://www.w3.org/TR/domcore/#dom-document-createtreewalker
Opera 12.00.1213 and FF 10.0 needs 3rd and 4th argument:

//In Opera and FF filter and entityExpandBol can't be undefined
document.createTreeWalker(root, nodesToShow, filter, entityExpandBol);

DOM4 spec says what filter is an optional "argument" and "entityExpandBol" argument not in DOM4 spec anymore

//this is valid
document.createTreeWalker(document.body, NodeFilter.ALL)
Owner

Raynos commented Jan 27, 2012

I have havn't implemented anything to do with TreeWalker, it's on the todo list though.

It should be noted that tree walkers are slow as hell and should be avoided for performance reasons.

Collaborator

termi commented Jan 27, 2012

I add issue only for "not forgotten" reason. I am now working on TreeWalker.

Is TreeWalker slow in all browsers (especially in Chrome) or only in browsers which have old implementation of TreeWalker ?

Collaborator

termi commented Jan 27, 2012

Do you mind of adding issue only for "not forgotten" reason? I find new bug in Opera with element.dataset http://jsfiddle.net/RPkJu/5/

Owner

Raynos commented Jan 27, 2012

@termi1uc1 http://stackoverflow.com/questions/7941288/when-to-use-nodeiterator

As for adding issues for "not forgotten" reason is fine.

I appreciate a back log of bugs on the "to fix" list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment