This repository has been archived by the owner. It is now read-only.

Display "missing app" icon in quicklaunch if the .desktop file is missing #413

Closed
jleclanche opened this Issue Sep 3, 2012 · 8 comments

Comments

4 participants
@jleclanche
Owner

jleclanche commented Sep 3, 2012

If we have a missing .desktop file in the quicklaunch, it is currently hidden and impossible to remove (the user doesnt know its there). It should be displayed as a missing file. It should have its own icon and its only context menu item should be "Remove [foo.desktop]"

@pvanek

This comment has been minimized.

Show comment Hide comment
@pvanek

pvanek Sep 4, 2012

Owner

hmm, it's easy to implement but I don't see any profit here...

Owner

pvanek commented Sep 4, 2012

hmm, it's easy to implement but I don't see any profit here...

@pvanek

This comment has been minimized.

Show comment Hide comment
@pvanek

pvanek May 17, 2013

Owner

I think it's resolved with current quicklaunch, right? There is a help text of there is nothing to display.

Owner

pvanek commented May 17, 2013

I think it's resolved with current quicklaunch, right? There is a help text of there is nothing to display.

@pvanek pvanek closed this May 17, 2013

@kuzmas

This comment has been minimized.

Show comment Hide comment
@kuzmas

kuzmas May 17, 2013

Member

@pvanek: isn't the stub text shown only when quicklaunch contains no icons at all? I think issue was with a .desktop file which impossible to display. If you have a single item in the quicklaunch which is broken - you will not have that help text.

Member

kuzmas commented May 17, 2013

@pvanek: isn't the stub text shown only when quicklaunch contains no icons at all? I think issue was with a .desktop file which impossible to display. If you have a single item in the quicklaunch which is broken - you will not have that help text.

@kuzmas kuzmas reopened this May 17, 2013

@pvanek

This comment has been minimized.

Show comment Hide comment
@pvanek

pvanek May 20, 2013

Owner

yes, the placeholder text is displayed when

a) there are no icons in startup
b) the last icon/widget is removed from layout

the check for a) to be included in layout is:

  • desktop file: XdgDesktopFile::isValid() has to retrun true for given desktop file
  • URL/file: file path must not be empty
  • legacy handling (exec/icon): icon must be provided

so for me it seems like "if your desktop file is not valid" works here (tested with non existing desktop files.

Owner

pvanek commented May 20, 2013

yes, the placeholder text is displayed when

a) there are no icons in startup
b) the last icon/widget is removed from layout

the check for a) to be included in layout is:

  • desktop file: XdgDesktopFile::isValid() has to retrun true for given desktop file
  • URL/file: file path must not be empty
  • legacy handling (exec/icon): icon must be provided

so for me it seems like "if your desktop file is not valid" works here (tested with non existing desktop files.

@pvanek pvanek closed this May 20, 2013

@kuzmas

This comment has been minimized.

Show comment Hide comment
@kuzmas

kuzmas May 20, 2013

Member

Great!

Member

kuzmas commented May 20, 2013

Great!

SokoloffA added a commit that referenced this issue May 21, 2013

@SokoloffA

This comment has been minimized.

Show comment Hide comment
@SokoloffA

SokoloffA May 21, 2013

Owner

Now quicklaunch check is .desktop:

  1. valid
  2. applicable - not hidden in this environment and tryExec check is true.

I think that's enough.

Owner

SokoloffA commented May 21, 2013

Now quicklaunch check is .desktop:

  1. valid
  2. applicable - not hidden in this environment and tryExec check is true.

I think that's enough.

@kuzmas

This comment has been minimized.

Show comment Hide comment
@kuzmas

kuzmas Jun 5, 2013

Member

After commit 88e3bb0 razor-power disappeared from my quicklaunch and cannot be inserted again.

details are here: 88e3bb0#commitcomment-3266325

Member

kuzmas commented Jun 5, 2013

After commit 88e3bb0 razor-power disappeared from my quicklaunch and cannot be inserted again.

details are here: 88e3bb0#commitcomment-3266325

@kuzmas kuzmas reopened this Jun 5, 2013

@kuzmas

This comment has been minimized.

Show comment Hide comment
@kuzmas

kuzmas Jun 5, 2013

Member

Fixed by 273f92e

Member

kuzmas commented Jun 5, 2013

Fixed by 273f92e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.