Display "missing app" icon in quicklaunch if the .desktop file is missing

[jleclanche]

If we have a missing .desktop file in the quicklaunch, it is currently hidden and impossible to remove (the user doesnt know its there). It should be displayed as a missing file. It should have its own icon and its only context menu item should be "Remove [foo.desktop]"

[pvanek]

hmm, it's easy to implement but I don't see any profit here...

[pvanek]

hmm, it's easy to implement but I don't see any profit here...

[pvanek]

I think it's resolved with current quicklaunch, right? There is a help text of there is nothing to display.

[pvanek]

I think it's resolved with current quicklaunch, right? There is a help text of there is nothing to display.

[kuzmas]

@pvanek: isn't the stub text shown only when quicklaunch contains no icons at all? I think issue was with a .desktop file which impossible to display. If you have a single item in the quicklaunch which is broken - you will not have that help text.

[kuzmas]

@pvanek: isn't the stub text shown only when quicklaunch contains no icons at all? I think issue was with a .desktop file which impossible to display. If you have a single item in the quicklaunch which is broken - you will not have that help text.

[pvanek]

yes, the placeholder text is displayed when

a) there are no icons in startup
b) the last icon/widget is removed from layout

the check for a) to be included in layout is:

• desktop file: XdgDesktopFile::isValid() has to retrun true for given desktop file
• URL/file: file path must not be empty
• legacy handling (exec/icon): icon must be provided

so for me it seems like "if your desktop file is not valid" works here (tested with non existing desktop files.

[pvanek]

yes, the placeholder text is displayed when

a) there are no icons in startup
b) the last icon/widget is removed from layout

the check for a) to be included in layout is:

• desktop file: XdgDesktopFile::isValid() has to retrun true for given desktop file
• URL/file: file path must not be empty
• legacy handling (exec/icon): icon must be provided

so for me it seems like "if your desktop file is not valid" works here (tested with non existing desktop files.

[kuzmas]

Great!

[kuzmas]

Great!

[SokoloffA]

Now quicklaunch check is .desktop:

1. valid
2. applicable - not hidden in this environment and tryExec check is true.

I think that's enough.

[SokoloffA]

Now quicklaunch check is .desktop:

1. valid
2. applicable - not hidden in this environment and tryExec check is true.

I think that's enough.

[kuzmas]

After commit 88e3bb0 razor-power disappeared from my quicklaunch and cannot be inserted again.

details are here: 88e3bb0#commitcomment-3266325

[kuzmas]

After commit 88e3bb0 razor-power disappeared from my quicklaunch and cannot be inserted again.

details are here: 88e3bb0#commitcomment-3266325

[kuzmas]

Fixed by 273f92e

[kuzmas]

Fixed by 273f92e