Cpuload: adjust text color with theme #553

Closed
xaviermiller opened this Issue Feb 14, 2013 · 18 comments

Projects

None yet

5 participants

@xaviermiller

Nice to have.

When I select the dark theme, the text of the CpuLoad plug-in is not readable unless the CPU load is high.

I see the desktop switcher adjusts its colors, so I guess it could be possible for the CpuLoad plug-in.

@xaviermiller

Here you can see what I mean (see the black 2(%) on the grey background; that is the CPUload plugin)
snap

@kuzmas
Razor-qt member

@xaviermiller Could you test the fixes, please, so we can close the bug?

@xaviermiller

Hello,

I don't see any change in the git sources (commit da51285)

@kuzmas
Razor-qt member

Mmmm, actually since da51285 there were a lot of changes. Look here: https://github.com/Razor-qt/razor-qt/commits/master
Try updating your sources (git pull).

@xaviermiller

sorry, I tought my tree was up-to-date. I just got a fresh clone, but I can't compile libqtxdg because a CMake error. I will try this later, in the next days.

@kuzmas
Razor-qt member

and what is the CMake error?

@xaviermiller
@amoskvin
Razor-qt member
@luis-pereira

@xaviermiller Can you please do the following at the root of the razor-qt repo:
mkdir build-test
cd build-test
cmake -DSPLIT_BUILD=Yes -DMODULE_QTXDG=YES -DCMAKE_BUILD_TYPE=debug ..

and post the output.

What cmake version are you running ?

@xaviermiller
@xaviermiller
@SokoloffA
Razor-qt member

@luis-pereira
qtxdg is a separate library, it used at least in one 3-d party project. So must be able to build it separately from the razor tree. And I think libraries/qtxdg/CMakeLists.txt should has a find_package Qt4 and cmake_minimum_required lines.

@luis-pereira

@SokoloffA That's why I posted https://groups.google.com/d/topic/razor-qt/g6ikl01jfnc/discussion
The changes can be easily reverted.

@amoskvin
Razor-qt member
@xaviermiller

Regarding the subject: it's OK for me.

But I will go back to the stable version because other blocking problems (width of the panel, when placed at the left of the screen)

@amoskvin
Razor-qt member

Thanks for testing!

@amoskvin amoskvin closed this Apr 25, 2013
@SokoloffA
Razor-qt member

I'm sorry that I haven't written before, and don't previewed code.

IMHO we on a wrong way.
Historically, the razor has a monolithic cmake structure. IMHO it's not good, would be good to be able build any parts of DE separately (especially plugins).

So my solutions, is create a cmake "XXX-config" files for libraries http://www.cmake.org/Wiki/CMake/Tutorials/How_to_create_a_ProjectConfig.cmake_file

As result we will have "find_package Qt" only in these several files. Al other files will use some like:

find_package(QTXDG REQUIRED)
include(${QTXDG_USE_FILE})

find_package(RAZOR REQUIRED)
include(${RAZOR_USE_FILE})

razor_translate_ts(NOTIFICATIONS_QM_FILES
    SOURCES
        ${HEADERS}
        ${SOURCES}
        ${FORMS}
)

Some time ago I worked on this, and have some results. But work wasn't finished, and now is outdated. Main problem was with "The following modules will be built" messages. This feature requires spaghetti code. If we can live without it (at least some time), I can resume work on it.

@amoskvin
Razor-qt member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment