This repository has been archived by the owner. It is now read-only.

Razor Panel opacity support and Main Menu Plugin icon size change support #299

Closed
wants to merge 3 commits into
base: master
from

Conversation

7 participants
@Devoter

Devoter commented May 25, 2012

Razor panel composite opacity support has been added.
Razor Panel Main Menu Plugin icon size change support has been added.

@amoskvin

This comment has been minimized.

Show comment
Hide comment
@amoskvin

amoskvin May 25, 2012

Member

I like the code cleanup for the panel configuration.

But icon resizing still does not work :(

On Friday 25 May 2012 05:52:16, Alexey Nosov wrote:

Razor panel composite opacity support has been added.
Razor Panel Main Menu Plugin icon size change support has been added.

You can merge this Pull Request by running:

git pull https://github.com/Devoter/razor-qt master

Or you can view, comment on it, or merge it online at:

#299

-- Commit Summary --

  • Panel Main Menu Plugin icon size change support added.
  • Merge remote-tracking branch 'original/master'
  • Panel Main Menu Plugin icon size change support added.

-- File Changes --

M razorqt-panel/panel/configpaneldialog.cpp (86)
M razorqt-panel/panel/configpaneldialog.h (18)
M razorqt-panel/panel/configpaneldialog.ui (33)
M razorqt-panel/panel/razorpanel.cpp (26)
M razorqt-panel/panel/razorpanel_p.h (5)
M razorqt-panel/plugin-mainmenu/CMakeLists.txt (5)
M razorqt-panel/plugin-mainmenu/razormainmenu.cpp (4)
M razorqt-panel/plugin-mainmenu/razormainmenuconfiguration.cpp (65)
M razorqt-panel/plugin-mainmenu/razormainmenuconfiguration.h (12)
M razorqt-panel/plugin-mainmenu/razormainmenuconfiguration.ui (51)
A razorqt-panel/plugin-mainmenu/razormainmenuspinbox.cpp (39)
A razorqt-panel/plugin-mainmenu/razormainmenuspinbox.h (46)

-- Patch Links --

https://github.com/Razor-qt/razor-qt/pull/299.patch
https://github.com/Razor-qt/razor-qt/pull/299.diff


Reply to this email directly or view it on GitHub:
#299

Member

amoskvin commented May 25, 2012

I like the code cleanup for the panel configuration.

But icon resizing still does not work :(

On Friday 25 May 2012 05:52:16, Alexey Nosov wrote:

Razor panel composite opacity support has been added.
Razor Panel Main Menu Plugin icon size change support has been added.

You can merge this Pull Request by running:

git pull https://github.com/Devoter/razor-qt master

Or you can view, comment on it, or merge it online at:

#299

-- Commit Summary --

  • Panel Main Menu Plugin icon size change support added.
  • Merge remote-tracking branch 'original/master'
  • Panel Main Menu Plugin icon size change support added.

-- File Changes --

M razorqt-panel/panel/configpaneldialog.cpp (86)
M razorqt-panel/panel/configpaneldialog.h (18)
M razorqt-panel/panel/configpaneldialog.ui (33)
M razorqt-panel/panel/razorpanel.cpp (26)
M razorqt-panel/panel/razorpanel_p.h (5)
M razorqt-panel/plugin-mainmenu/CMakeLists.txt (5)
M razorqt-panel/plugin-mainmenu/razormainmenu.cpp (4)
M razorqt-panel/plugin-mainmenu/razormainmenuconfiguration.cpp (65)
M razorqt-panel/plugin-mainmenu/razormainmenuconfiguration.h (12)
M razorqt-panel/plugin-mainmenu/razormainmenuconfiguration.ui (51)
A razorqt-panel/plugin-mainmenu/razormainmenuspinbox.cpp (39)
A razorqt-panel/plugin-mainmenu/razormainmenuspinbox.h (46)

-- Patch Links --

https://github.com/Razor-qt/razor-qt/pull/299.patch
https://github.com/Razor-qt/razor-qt/pull/299.diff


Reply to this email directly or view it on GitHub:
#299

@Devoter

This comment has been minimized.

Show comment
Hide comment
@Devoter

Devoter May 25, 2012

It works for me. What are you doing? Do you have the previous effect? Did you remove the focus from the spin box?

Devoter commented May 25, 2012

It works for me. What are you doing? Do you have the previous effect? Did you remove the focus from the spin box?

@amoskvin

This comment has been minimized.

Show comment
Hide comment
@amoskvin

amoskvin May 25, 2012

Member

It looks just like last time.

Here's what I did:

  • Change the theme to Plastique (to make sure the theme is not messing it up)
  • Change the icon size to 48px
  • Log out and back in
  • Click the menu

On Friday 25 May 2012 07:02:36, Alexey Nosov wrote:

It works for me. What are you doing? Do you have the previous effect? Did you remove the focus from the spin box?

Member

amoskvin commented May 25, 2012

It looks just like last time.

Here's what I did:

  • Change the theme to Plastique (to make sure the theme is not messing it up)
  • Change the icon size to 48px
  • Log out and back in
  • Click the menu

On Friday 25 May 2012 07:02:36, Alexey Nosov wrote:

It works for me. What are you doing? Do you have the previous effect? Did you remove the focus from the spin box?

@Devoter

This comment has been minimized.

Show comment
Hide comment
@Devoter

Devoter May 25, 2012

Sorry, I cannot reproduce this bug. Maybe, someone can do it. Do you have any additional patches, except this?

Devoter commented May 25, 2012

Sorry, I cannot reproduce this bug. Maybe, someone can do it. Do you have any additional patches, except this?

@mckaygerhard

This comment has been minimized.

Show comment
Hide comment
@mckaygerhard

mckaygerhard May 25, 2012

Contributor

please report what verson of qt4 do u have.. and what version of xrender and xcomposite, maybe this feature requires composite desktop.. i'll see code for that..

Contributor

mckaygerhard commented May 25, 2012

please report what verson of qt4 do u have.. and what version of xrender and xcomposite, maybe this feature requires composite desktop.. i'll see code for that..

@Devoter

This comment has been minimized.

Show comment
Hide comment
@Devoter

Devoter May 25, 2012

Sure, qt using composite extension. This is a simply function: void QWidget::setWindowOpacity(qreal level);

Devoter commented May 25, 2012

Sure, qt using composite extension. This is a simply function: void QWidget::setWindowOpacity(qreal level);

@luis-pereira

This comment has been minimized.

Show comment
Hide comment
@luis-pereira

luis-pereira May 31, 2012

Contributor

IMO This pull request should be splitted into two pull requests:

  • Panel opacity support;
  • Main Menu Plugin icon size change support.

Each pull request should only be about one thing. It leads to a cleaner and more focused discussion. And also to a
cleaner and more understandable history.

I have comments about the two features.
Devoter, Can you split this pull request ?

Contributor

luis-pereira commented May 31, 2012

IMO This pull request should be splitted into two pull requests:

  • Panel opacity support;
  • Main Menu Plugin icon size change support.

Each pull request should only be about one thing. It leads to a cleaner and more focused discussion. And also to a
cleaner and more understandable history.

I have comments about the two features.
Devoter, Can you split this pull request ?

@Devoter

This comment has been minimized.

Show comment
Hide comment
@Devoter

Devoter May 31, 2012

I have to continue develop the panel opacity feature, because it doesn't works fine. I don't have a time to do some useless work. If you want to discuss and split - do it (my fork is open :) ) I just want to develop, not to gab.

Devoter commented May 31, 2012

I have to continue develop the panel opacity feature, because it doesn't works fine. I don't have a time to do some useless work. If you want to discuss and split - do it (my fork is open :) ) I just want to develop, not to gab.

@luis-pereira

This comment has been minimized.

Show comment
Hide comment
@luis-pereira

luis-pereira May 31, 2012

Contributor

Well, by discuss, I meant fix it.
Discussion is part of development. Not an useless thing.
The pull request is yours, it's up to you and/or the maintainers to decide to split or not split. I can make the split but only if you agree with it.

I've fixed panel opacity. Please check my screenshot at http://imgur.com/IfpgV
But... there are other issues with opacity that need to be addressed, and I really want to discuss it before writing the code.

I've also found the bug that amoskvin is talking about. Didn't wrote the patch yet.
There are also other issues regarding icon size change. I hope I can discuss it with you.

Regards

Contributor

luis-pereira commented May 31, 2012

Well, by discuss, I meant fix it.
Discussion is part of development. Not an useless thing.
The pull request is yours, it's up to you and/or the maintainers to decide to split or not split. I can make the split but only if you agree with it.

I've fixed panel opacity. Please check my screenshot at http://imgur.com/IfpgV
But... there are other issues with opacity that need to be addressed, and I really want to discuss it before writing the code.

I've also found the bug that amoskvin is talking about. Didn't wrote the patch yet.
There are also other issues regarding icon size change. I hope I can discuss it with you.

Regards

@Devoter

This comment has been minimized.

Show comment
Hide comment
@Devoter

Devoter May 31, 2012

Sorry, it was a bad day. I have got the fix from Alex Sokolov and I'll insert it into my code. Previous opacity feature works fine with Qt >=4.8.1.

If you know how to fix icon size change bug I'll be happy to listen you.

Devoter commented May 31, 2012

Sorry, it was a bad day. I have got the fix from Alex Sokolov and I'll insert it into my code. Previous opacity feature works fine with Qt >=4.8.1.

If you know how to fix icon size change bug I'll be happy to listen you.

@mckaygerhard

This comment has been minimized.

Show comment
Hide comment
@mckaygerhard

mckaygerhard May 31, 2012

Contributor

but there's no happy eith this requerimients.. i dont have this
release of qt4..

either my other computers.. the most recent version i hav are 4.7.2 ..
and the most used are 4.6 an 4.6.3

On Thu, May 31, 2012 at 10:37 AM, Alexey Nosov
reply@reply.github.com
wrote:

Sorry, it was a bad day. I have got the fix from Alex Sokolov and I'll insert it into my code. Previous opacity feature works fine with Qt >=4.8.1.

If you know how to fix icon size change bug I'll be happy to listen you.


Reply to this email directly or view it on GitHub:
#299 (comment)

Lenz McKAY Gerardo (PICCORO)
http://qgqlochekone.blogspot.com
Cofundador de Venenux;  debian based multimedia alike free only
zealots users (oh well, i try but..too many free guidelines buahhh)
http://shutendouji.net
creador de massenkoh linux; debian enhanchements for better up to date
support on stable brand, including non-free soft.

Contributor

mckaygerhard commented May 31, 2012

but there's no happy eith this requerimients.. i dont have this
release of qt4..

either my other computers.. the most recent version i hav are 4.7.2 ..
and the most used are 4.6 an 4.6.3

On Thu, May 31, 2012 at 10:37 AM, Alexey Nosov
reply@reply.github.com
wrote:

Sorry, it was a bad day. I have got the fix from Alex Sokolov and I'll insert it into my code. Previous opacity feature works fine with Qt >=4.8.1.

If you know how to fix icon size change bug I'll be happy to listen you.


Reply to this email directly or view it on GitHub:
#299 (comment)

Lenz McKAY Gerardo (PICCORO)
http://qgqlochekone.blogspot.com
Cofundador de Venenux;  debian based multimedia alike free only
zealots users (oh well, i try but..too many free guidelines buahhh)
http://shutendouji.net
creador de massenkoh linux; debian enhanchements for better up to date
support on stable brand, including non-free soft.

@Devoter

This comment has been minimized.

Show comment
Hide comment
@Devoter

Devoter May 31, 2012

I said PREVOIUS version of opacity feature works fine with Qt 4.8.1. Alexander has wrote a fix that works fine with Qt 4.6 and I'll include it into my code.

Devoter commented May 31, 2012

I said PREVOIUS version of opacity feature works fine with Qt 4.8.1. Alexander has wrote a fix that works fine with Qt 4.6 and I'll include it into my code.

@mckaygerhard

This comment has been minimized.

Show comment
Hide comment
@mckaygerhard

mckaygerhard May 31, 2012

Contributor

^_^

yeahhhh .. i just confirmed.. thanks.

On Thu, May 31, 2012 at 10:56 AM, Alexey Nosov
reply@reply.github.com
wrote:

I said PREVOIUS version of opacity feature works fine with Qt 4.8.1. Alexander has wrote a fix that works fine with Qt 4.6 and I'll include it into my code.


Reply to this email directly or view it on GitHub:
#299 (comment)

Lenz McKAY Gerardo (PICCORO)
http://qgqlochekone.blogspot.com
Cofundador de Venenux;  debian based multimedia alike free only
zealots users (oh well, i try but..too many free guidelines buahhh)
http://shutendouji.net
creador de massenkoh linux; debian enhanchements for better up to date
support on stable brand, including non-free soft.

Contributor

mckaygerhard commented May 31, 2012

^_^

yeahhhh .. i just confirmed.. thanks.

On Thu, May 31, 2012 at 10:56 AM, Alexey Nosov
reply@reply.github.com
wrote:

I said PREVOIUS version of opacity feature works fine with Qt 4.8.1. Alexander has wrote a fix that works fine with Qt 4.6 and I'll include it into my code.


Reply to this email directly or view it on GitHub:
#299 (comment)

Lenz McKAY Gerardo (PICCORO)
http://qgqlochekone.blogspot.com
Cofundador de Venenux;  debian based multimedia alike free only
zealots users (oh well, i try but..too many free guidelines buahhh)
http://shutendouji.net
creador de massenkoh linux; debian enhanchements for better up to date
support on stable brand, including non-free soft.

@luis-pereira

This comment has been minimized.

Show comment
Hide comment
Contributor

luis-pereira commented May 31, 2012

@luis-pereira

This comment has been minimized.

Show comment
Hide comment
@luis-pereira

luis-pereira May 31, 2012

Contributor

If you know how to fix icon size change bug I'll be happy to listen you

Actually I was talking about the panel size. Sorry :(
Maybe amoskvin was too.

Contributor

luis-pereira commented May 31, 2012

If you know how to fix icon size change bug I'll be happy to listen you

Actually I was talking about the panel size. Sorry :(
Maybe amoskvin was too.

@SokoloffA

This comment has been minimized.

Show comment
Hide comment
@SokoloffA

SokoloffA Jun 1, 2012

Member

@amoskvin @luis-pereira
Icon size working for me, but only with the ambiance theme.
Please set the ambiance theme and try to change the icon size. Perhaps a theme fix we be enough.

Member

SokoloffA commented Jun 1, 2012

@amoskvin @luis-pereira
Icon size working for me, but only with the ambiance theme.
Please set the ambiance theme and try to change the icon size. Perhaps a theme fix we be enough.

@luis-pereira

This comment has been minimized.

Show comment
Hide comment
@luis-pereira

luis-pereira Jun 1, 2012

Contributor

On Fri, Jun 1, 2012 at 10:50 AM, Alexander Sokolov
reply@reply.github.com
wrote:

Icon size working for me, but only with the ambiance theme.
Please set the ambiance theme and try to change the icon size. Perhaps a theme fix we be enough.

Yes, It has something to do with the theme also.
On the other hand there is a bug when loading the saved settings to
the configuration UI. I have a patch for that.
But I think that the theme bug (along with the one i wrote a patch)
isn't the only one. Even with the ambiance theme I get some strange
behavior. I will dig into that
In the meantime I will push the patch to my repo.

Contributor

luis-pereira commented Jun 1, 2012

On Fri, Jun 1, 2012 at 10:50 AM, Alexander Sokolov
reply@reply.github.com
wrote:

Icon size working for me, but only with the ambiance theme.
Please set the ambiance theme and try to change the icon size. Perhaps a theme fix we be enough.

Yes, It has something to do with the theme also.
On the other hand there is a bug when loading the saved settings to
the configuration UI. I have a patch for that.
But I think that the theme bug (along with the one i wrote a patch)
isn't the only one. Even with the ambiance theme I get some strange
behavior. I will dig into that
In the meantime I will push the patch to my repo.

@amoskvin

This comment has been minimized.

Show comment
Hide comment
@amoskvin

amoskvin Jun 1, 2012

Member

You're right - it works with ambiance.

Speaking of themes ... shouldn't it be the theme that determines the
icon size, considering how the theme is also supposed to determine things
like the panel size?

Member

amoskvin commented Jun 1, 2012

You're right - it works with ambiance.

Speaking of themes ... shouldn't it be the theme that determines the
icon size, considering how the theme is also supposed to determine things
like the panel size?

@luis-pereira

This comment has been minimized.

Show comment
Hide comment
@luis-pereira

luis-pereira Jun 2, 2012

Contributor

On Fri, Jun 1, 2012 at 11:48 AM, Luís Pereira
luis.artur.pereira@gmail.com wrote:

Icon size working for me, but only with the ambiance theme.
Please set the ambiance theme and try to change the icon size. Perhaps a theme fix we be enough.

Yes, It has something to do with the theme also.
On the other hand there is a bug when loading the saved settings to
the configuration UI. I have a patch for that.
But I think that the theme bug  (along with the one i wrote a patch)
isn't the only one. Even with the ambiance theme I get some strange
behavior. I will dig into that
In the meantime I will push the patch to my repo.

Well, I was talking about panel size. Sorry for the noise.

Contributor

luis-pereira commented Jun 2, 2012

On Fri, Jun 1, 2012 at 11:48 AM, Luís Pereira
luis.artur.pereira@gmail.com wrote:

Icon size working for me, but only with the ambiance theme.
Please set the ambiance theme and try to change the icon size. Perhaps a theme fix we be enough.

Yes, It has something to do with the theme also.
On the other hand there is a bug when loading the saved settings to
the configuration UI. I have a patch for that.
But I think that the theme bug  (along with the one i wrote a patch)
isn't the only one. Even with the ambiance theme I get some strange
behavior. I will dig into that
In the meantime I will push the patch to my repo.

Well, I was talking about panel size. Sorry for the noise.

@SokoloffA

This comment has been minimized.

Show comment
Hide comment
@SokoloffA

SokoloffA Jun 3, 2012

Member

If you look on screenshots in the internet, you can see that most users are
using the standard theme, icons and panel size.

So my initial idea was:
We provide the set of the pretty looking themes, some for the big monitors,
another for notebooks. They looks balanced, icon size, paddings/margings,
font size e.t.c. User should only select appropriate theme, instead the
long customize. By this reason i fighted for the panel auto size, some time
ago.

But now this looks that we killed this idea (to my regret).

2012/6/1 Alec Moskvin <
reply@reply.github.com

You're right - it works with ambiance.

Speaking of themes ... shouldn't it be the theme that determines the
icon size, considering how the theme is also supposed to determine things
like the panel size?


Reply to this email directly or view it on GitHub:
#299 (comment)

Best regards,
Alexander.

Member

SokoloffA commented Jun 3, 2012

If you look on screenshots in the internet, you can see that most users are
using the standard theme, icons and panel size.

So my initial idea was:
We provide the set of the pretty looking themes, some for the big monitors,
another for notebooks. They looks balanced, icon size, paddings/margings,
font size e.t.c. User should only select appropriate theme, instead the
long customize. By this reason i fighted for the panel auto size, some time
ago.

But now this looks that we killed this idea (to my regret).

2012/6/1 Alec Moskvin <
reply@reply.github.com

You're right - it works with ambiance.

Speaking of themes ... shouldn't it be the theme that determines the
icon size, considering how the theme is also supposed to determine things
like the panel size?


Reply to this email directly or view it on GitHub:
#299 (comment)

Best regards,
Alexander.

@luis-pereira

This comment has been minimized.

Show comment
Hide comment
@luis-pereira

luis-pereira Jun 8, 2012

Contributor

On Sun, Jun 3, 2012 at 12:49 PM, Alexander Sokolov <
reply@reply.github.com

wrote:

So my initial idea was:
We provide the set of the pretty looking themes, some for the big monitors,
another for notebooks. They looks balanced, icon size, paddings/margings,
font size e.t.c. User should only select appropriate theme, instead the
long customize. By this reason i fighted for the panel auto size, some time
ago.

I'm working on the panel size stuff. I would like to discuss this
question.... but probably the right place is the mailing list.
I will open an thread.

Contributor

luis-pereira commented Jun 8, 2012

On Sun, Jun 3, 2012 at 12:49 PM, Alexander Sokolov <
reply@reply.github.com

wrote:

So my initial idea was:
We provide the set of the pretty looking themes, some for the big monitors,
another for notebooks. They looks balanced, icon size, paddings/margings,
font size e.t.c. User should only select appropriate theme, instead the
long customize. By this reason i fighted for the panel auto size, some time
ago.

I'm working on the panel size stuff. I would like to discuss this
question.... but probably the right place is the mailing list.
I will open an thread.

@pvanek

This comment has been minimized.

Show comment
Hide comment
@pvanek

pvanek Jun 26, 2012

Member

any progress here?

Member

pvanek commented Jun 26, 2012

any progress here?

@luis-pereira

This comment has been minimized.

Show comment
Hide comment
@luis-pereira

luis-pereira Jun 27, 2012

Contributor

Yes, some progress.
I have to organize it though

Contributor

luis-pereira commented Jun 27, 2012

Yes, some progress.
I have to organize it though

@jleclanche

This comment has been minimized.

Show comment
Hide comment
@jleclanche

jleclanche Jul 28, 2012

Member

Its been a month, quick status update?

Member

jleclanche commented Jul 28, 2012

Its been a month, quick status update?

@luis-pereira

This comment has been minimized.

Show comment
Hide comment
@luis-pereira

luis-pereira Jul 30, 2012

Contributor

On Sat, Jul 28, 2012 at 1:50 PM, Jerome Leclanche
reply@reply.github.com
wrote:

Its been a month, quick status update?

My reply to Petr was about the panel size stuff, which as already been merged.

    Luís Pereira
Contributor

luis-pereira commented Jul 30, 2012

On Sat, Jul 28, 2012 at 1:50 PM, Jerome Leclanche
reply@reply.github.com
wrote:

Its been a month, quick status update?

My reply to Petr was about the panel size stuff, which as already been merged.

    Luís Pereira
@jleclanche

This comment has been minimized.

Show comment
Hide comment
@jleclanche

jleclanche Jul 30, 2012

Member

Closing the pull request then. Devoter, if you get further with the panel opacity work, please send a new one.

Member

jleclanche commented Jul 30, 2012

Closing the pull request then. Devoter, if you get further with the panel opacity work, please send a new one.

@jleclanche jleclanche closed this Jul 30, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.