Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBEQS Empty column fix - Closes #99 #100
Conversation
Fix eqs empty columns
| if(!all_chk){ // Check if any columns have not been checked successfully - these will all set to fallback NA | ||
| for (int i=0; i<cols; i++) { | ||
| if(!chk[i]){ | ||
| lst[i] = Rcpp::CharacterVector(rows, R_NaString); |
eddelbuettel
Nov 23, 2015
Member
That doesn't work.
We may be one of four types here. You are assuming it is always character when it might be numeric or date or ... and you cannot assign a character-NA to these others.
We might be able to assign R_NilValue.
That doesn't work.
We may be one of four types here. You are assuming it is always character when it might be numeric or date or ... and you cannot assign a character-NA to these others.
We might be able to assign R_NilValue.
csrvermaak
Nov 23, 2015
Author
Contributor
100% - happy to append. What class should it be: RawVector or GenericVector?
100% - happy to append. What class should it be: RawVector or GenericVector?
eddelbuettel
Nov 23, 2015
Member
I spoke to soon. Your logic is to fill the entire column j if it was never set? So that could work.
My preferred NA is numeric, but that is a small thing.
I spoke to soon. Your logic is to fill the entire column j if it was never set? So that could work.
My preferred NA is numeric, but that is a small thing.
csrvermaak
Nov 23, 2015
Author
Contributor
Yes, the logic is: search for a type until found, then stop searching.
If no type found, there was no value in the column, thus entire column is NA.
Yes, the logic is: search for a type until found, then stop searching.
If no type found, there was no value in the column, thus entire column is NA.
eddelbuettel
Nov 23, 2015
Member
Which even I understood once I got to the third cup'o'joe ;-)
Thanks for the enhancement!
Which even I understood once I got to the third cup'o'joe ;-)
Thanks for the enhancement!
BEQS Empty column fix - Closes #99
No description provided.