Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upgetBars options vector #105
Conversation
|
You're not making a ton of sense as this one is still 'dirty' -- including dll files we clearly do not want. (Hint: friends don't let friends use I'll merge and clean up after you. |
|
Do you have a legal name you would care to share so that I can give you proper credit in the ChangeLog file ? |
|
Thanks very much and sorry about that. Next time I will ensure it is clean (I had offered to do this on Monday - I am on mobile only this weekend). As I mentioned in the old pull request I think this needs defaults for some options. Any advice on the preferred way to support this would be welcome! |
|
Is it fine just to use my user ID for now?
|
|
Then I would not have asked you. I have the id. |
@eddelbuettel as you mentioned my commit was "dirty". Sorry about that. I can resubmit clean on Monday or you can take this one and clean it up. Whatever works for you.