Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getBars options vector #105

Merged
merged 5 commits into from Dec 5, 2015
Merged

getBars options vector #105

merged 5 commits into from Dec 5, 2015

Conversation

@joel23888
Copy link
Contributor

@joel23888 joel23888 commented Dec 5, 2015

@eddelbuettel as you mentioned my commit was "dirty". Sorry about that. I can resubmit clean on Monday or you can take this one and clean it up. Whatever works for you.

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 5, 2015

You're not making a ton of sense as this one is still 'dirty' -- including dll files we clearly do not want. (Hint: friends don't let friends use git commit -a, stage files manually or from a GUI).

I'll merge and clean up after you.

eddelbuettel added a commit that referenced this pull request Dec 5, 2015
getBars options vector
@eddelbuettel eddelbuettel merged commit 23bd707 into Rblp:master Dec 5, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eddelbuettel added a commit that referenced this pull request Dec 5, 2015
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 5, 2015

Do you have a legal name you would care to share so that I can give you proper credit in the ChangeLog file ?

@joel23888
Copy link
Contributor Author

@joel23888 joel23888 commented Dec 5, 2015

Thanks very much and sorry about that. Next time I will ensure it is clean (I had offered to do this on Monday - I am on mobile only this weekend). As I mentioned in the old pull request I think this needs defaults for some options. Any advice on the preferred way to support this would be welcome!

@joel23888
Copy link
Contributor Author

@joel23888 joel23888 commented Dec 5, 2015

Is it fine just to use my user ID for now?
On Sat, Dec 5, 2015 at 11:01 Dirk Eddelbuettel notifications@github.com
wrote:

Do you have a legal name you would care to share so that I can give you
proper credit in the ChangeLog file
https://github.com/Rblp/Rblpapi/blob/master/ChangeLog ?


Reply to this email directly or view it on GitHub
#105 (comment).

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 5, 2015

Then I would not have asked you. I have the id.

eddelbuettel added a commit that referenced this pull request Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.