Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unit testing #129

Merged
merged 2 commits into from Feb 25, 2016
Merged

Feature/unit testing #129

merged 2 commits into from Feb 25, 2016

Conversation

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Feb 24, 2016

Proof of concept with two functions and eight tests for getBars

Requires that you create ~/.R/rblpapiOptions.R with the options() snippet otherwise in Rprofile as the latter is not read during tests.

currently (?) requires a new file ~/.R/rblpapiOptions.R as ~/.Rprofile is NOT read
armstrtw added a commit that referenced this pull request Feb 25, 2016
Feature/unit testing
@armstrtw armstrtw merged commit 714f986 into master Feb 25, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel
Copy link
Member Author

@eddelbuettel eddelbuettel commented Feb 25, 2016

Thanks. You may want to play with it -- ie force a FALSE && into one of the tests to see it fail.

@eddelbuettel eddelbuettel deleted the feature/unit-testing branch Feb 25, 2016
@armstrtw
Copy link
Contributor

@armstrtw armstrtw commented Feb 25, 2016

thx. I'm almost done w/ the code change. but when I push to the feature branch, we should all test a bit first...

@eddelbuettel
Copy link
Member Author

@eddelbuettel eddelbuettel commented Feb 25, 2016

Right. But the idea is that you as author of the code in question may be best positioned to formalize some tests that would get run automatically (if and when unit tests get tickled and can actually run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.