Skip to content

/ Rblpapi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date passed as double #141

Merged
merged 2 commits into from Mar 2, 2016
Merged

Fix date passed as double #141

merged 2 commits into from Mar 2, 2016

Conversation

@armstrtw
Copy link
Contributor

@armstrtw armstrtw commented Mar 2, 2016

fixes #102
armstrtw added 2 commits Mar 2, 2016
@armstrtw
add const int bbgDateToJulianDate(const double yyyymmdd_date) and add…
4cc9c0c 
… logic to populateDfRow to handle dates passed down as doubles
@armstrtw
add unit test test.bdhDateAsDouble to check for handling ECO_RELEASE_…
Loading status checks…
0112985 
…DT from a bdh request (when bbg returns date as double)
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Mar 2, 2016

Great -- will merge in a bit (just waiting for the darn Travis run)
eddelbuettel added a commit that referenced this pull request Mar 2, 2016
@eddelbuettel
Merge pull request #141 from Rblp/fix-date-passed-as-double
Loading status checks…
53dbbff 
Fix date passed as double
@eddelbuettel eddelbuettel merged commit 53dbbff into master Mar 2, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@armstrtw armstrtw deleted the fix-date-passed-as-double branch Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Error in bdp_Impl: attempt to set an attribute on NULL
2 participants
@armstrtw @eddelbuettel
You can’t perform that action at this time.