Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version string helpers #161

Merged
merged 4 commits into from Apr 4, 2016
Merged

new version string helpers #161

merged 4 commits into from Apr 4, 2016

Conversation

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Apr 3, 2016

No description provided.

R/init.R Outdated
@@ -21,12 +21,16 @@
.pkgenv <- new.env(parent=emptyenv())

.onAttach <- function(libname, pkgname) {
if (getOption("blpVerbose", FALSE)) {

This comment has been minimized.

@eddelbuettel

eddelbuettel Apr 3, 2016
Author Member

I am thinking we could even make this unconditional, as users can still suppress startup messages via suppressMessages() and suppressPackageStartupMessages().

This comment has been minimized.

@johnlaing

johnlaing Apr 4, 2016
Contributor

Yes, I'm in favor of making this unconditional. Not something that needs to be attached to a global option.

This comment has been minimized.

@eddelbuettel

eddelbuettel Apr 4, 2016
Author Member

Me too -- and done!

@armstrtw armstrtw merged commit cca2ba7 into master Apr 4, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the feature/blpVersion branch Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.