add support for portfolio data (closes #169) #176

Merged
merged 2 commits into from Jun 6, 2016

Projects

None yet

3 participants

@johnlaing
Contributor

No description provided.

@johnlaing johnlaing add support for portfolio data via bds backend
2eef6ed
@eddelbuettel
Member

Looks great. Only minor question (or suggestion): should it be getPortfolio() for consistence as it is a getter? Or not because bds, bdp, bdh, ... are shorthand?

@johnlaing
Contributor

I don't have a preference either way. Happy to change if you'd like.

@eddelbuettel
Member

As a user (and author) I do prefer getFoo() for various foo, so if you're up for a search+replace I think it makes it easier. But as I said, here we do have counter examples -- and if the Bloomberg documentation refers to 'portfolio' as a function ... So your call.

@johnlaing
Contributor

I'll change it. I like bdp/bds/bdh for their simplicity, but there are others like getTicks. I suppose this is more similar to the latter.

@johnlaing johnlaing rename as getter
db8e08e
@armstrtw armstrtw merged commit f764f0e into master Jun 6, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@wmorgan85 wmorgan85 referenced this pull request Jul 12, 2016
Closed

Portfolio Data Request #62

@eddelbuettel eddelbuettel deleted the feature/portfolio-data branch Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment