Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use double for int32 and int64 field types in bdh (closes #163) #205

Merged
merged 3 commits into from Nov 18, 2016

Conversation

@armstrtw
Copy link
Contributor

@armstrtw armstrtw commented Nov 18, 2016

No description provided.

@eddelbuettel eddelbuettel changed the title use double for int32 and int64 field types in bdh, resolves #163 use double for int32 and int64 field types in bdh (closes #163) Nov 18, 2016
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Nov 18, 2016

Looks good!

Copy link
Member

@eddelbuettel eddelbuettel left a comment

Nice. Doubly so with a test case.

@eddelbuettel eddelbuettel merged commit 40a6ac4 into master Nov 18, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the bdh-use-double branch Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.