Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #274. Remove src/init.c and use the newer version of compileAt… #275

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
3 participants
@DavisVaughan
Copy link
Contributor

DavisVaughan commented Jul 25, 2018

…tributes()

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jul 25, 2018

@johnlaing @armstrtw Anybody seconding this?

@johnlaing

This comment has been minimized.

Copy link
Contributor

johnlaing commented Jul 26, 2018

RcppExports is all magic to me, I don't really understand any of this. If it's good to you I certainly don't object.

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Jul 26, 2018

Hehe. src/RcppExport.cpp and its sibbling in R/ are surely magical, and very convenient.

Here the issue simply is/was that we had hand-written / generated by a tool from R code for registration in src/init.c, and by now compileAttributes() does this for us and adds it to src/RcppExports.cpp. The PR simply updates to this.

So ... merging.

@eddelbuettel eddelbuettel merged commit cdcc53e into Rblp:master Jul 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.