Skip to content

/ Rblpapi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize DateVector() with NAs #279

Merged
merged 2 commits into from Oct 26, 2018
Merged

initialize DateVector() with NAs #279

merged 2 commits into from Oct 26, 2018

Conversation

@shrektan
Copy link
Contributor

@shrektan shrektan commented Oct 25, 2018 •
edited

Fix a bug introduced by PR #273

See the comments in PR #278

library(Rblpapi)
blpConnect()
out <- bdp(securities = c("BBG006YQMFQ5", "BBG005CMJQ71"),
           fields = c("ISSUE_DT"))

out$ISSUE_DT
# before this PR, it returns 1970-01-01
# after this PR, it returns NA as before (the CRAN version)
@shrektan
initialize DateVector() with NAs
Loading status checks…
c4dd916
@shrektan shrektan mentioned this pull request Oct 25, 2018
Merged
@johnlaing
add test for NA date value
Loading status checks…
caabfcb
@johnlaing johnlaing merged commit 14b0aa5 into Rblp:master Oct 26, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shrektan shrektan deleted the shrektan:nadatevector branch Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@shrektan @johnlaing
You can’t perform that action at this time.