Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upunique-ify timestamps before merge of multiple ticks (closes #76) #77
Conversation
johnlaing
added a commit
that referenced
this pull request
Oct 1, 2015
unique-ify timestamps before merge of multiple ticks (closes #76)
|
This looks straightforward enough, but I don't use |
|
You did read that I write 'pending testing', right? ;-) |
|
I did, but I misunderstood what you meant. To me, a pull request means "this is ready to go". So I merged it... |
|
How about if we agree that PRs are invitation for comment by other team members. If I wanted to commit directly, I would (and do, for trivial things). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Pending more testing against live data, thanks to @joshuaulrich for the follow-up yesterday.
I'll follow up here if once I hear from the colleague you spotted the "infelicity" in the first place.