Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bdh.R Example #93

Merged
merged 1 commit into from Nov 16, 2015
Merged

Update bdh.R Example #93

merged 1 commit into from Nov 16, 2015

Conversation

@csrvermaak
Copy link
Contributor

@csrvermaak csrvermaak commented Nov 16, 2015

The BDH() example for an options field doesn't work as per the manual:

>opt <- c("periodicityAdjustment"="MONTHLY")
>bdh("SPY US Equity", c("PX_LAST", "VOLUME"),  start.date=Sys.Date()-31*6, options=opt)

Error: Enumeration type could not be found for MONTHLY

The correct override name is opt <- c("periodicitySelection"="MONTHLY")

>opt <- c("periodicitySelection"="MONTHLY")
>bdh("SPY US Equity", c("PX_LAST", "VOLUME"),  start.date=Sys.Date()-31*6, options=opt)

       date PX_LAST    VOLUME
1  2015-10-16  203.27 114580052
2  2015-10-19  203.37  76523897

The BDH() example for an options field doesn't work as per the manual:

```
Error: Enumeration type could not be found for MONTHLY
```

The correct override name is **opt <- c("periodicitySelection"="MONTHLY")**
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Nov 16, 2015

Thank you -- looks good. That is the problem of the lack of unit tests ...

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Nov 16, 2015

Nice catch. I am so sure I tested this before putting into the examples section. Oh well.

eddelbuettel added a commit that referenced this pull request Nov 16, 2015
Update bdh.R Example
@eddelbuettel eddelbuettel merged commit a99d23e into Rblp:master Nov 16, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Nov 16, 2015

(You did forget to run roxygenize() though.)

eddelbuettel added a commit that referenced this pull request Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.