Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap pre-built pdf vignettes #1004

Closed
eddelbuettel opened this issue Oct 25, 2019 · 2 comments
Closed

Wrap pre-built pdf vignettes #1004

eddelbuettel opened this issue Oct 25, 2019 · 2 comments

Comments

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Oct 25, 2019

Our vignettes do not change that much, and do not contain much "test" code that adds to the decent coverage we have from unit testing.

But building all nine pdf vignettes takes on the order of two minutes. Given that the content does not really change all that much, the time may not be well spent.

Moreover, the toolchain changes every now and then. Recently we had an issue in the pinp package (providing the Markdown/LaTeX parts); rmarkdown or pandoc also change over the years. We may as well shield Rcpp from this.

The branch vignettes_premade has a set of changes which uses a standard trick of having a minimal Sweave/LaTeX vignette "including" another pdf file. I added Makefiles to make the actual 'underlying' vignettes from rmd, and the wrapper vignettes.

If there are no objections, I plan to make this a pr in a day or two (I need to add wrappers for two of the nine vignettes) and then merge.

Comments welcome and appreciated, as always!

@kevinushey

This comment has been minimized.

Copy link
Contributor

@kevinushey kevinushey commented Oct 25, 2019

Sounds good to me!

Just to check, have we ever had an issue in Rcpp that was caught during building of vignettes, but not during running of the test suite for some reason? As far as I can recall, this has never occurred but your memory may be better than mine.

@eddelbuettel

This comment has been minimized.

Copy link
Member Author

@eddelbuettel eddelbuettel commented Oct 25, 2019

I like the empirical angle. And just like you I also cannot think of an issue it triggered. I think there was general test fickleness. I recall that for quite some time (when files were in Rnw before being converted to Rmd) they had code that "looked like" evaluation snippets but they were all set to false anyway...

I guess having the vignettes fail helps for issue like the recent pinp issue (which at the end an error on my end on the latex side tickled by a new texlive) so in that sense reducing the test surface is not nice. But then again it also does not help that CRAN doesn't even have enough time for all our tests.---many are conditioned away unless a 'yes we really want to test' variable is set as our test runner does , or as we do with the a.b.c.d scheme which tests whereas releases in a.b.c form don't.

Long story short I also don't recall the vignettes saving us. These days the real test are the reverse depends anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.