Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider updating RCPP_VERSION etc. automatically at build time #1021

Closed
kevinushey opened this issue Nov 11, 2019 · 1 comment
Closed

consider updating RCPP_VERSION etc. automatically at build time #1021

kevinushey opened this issue Nov 11, 2019 · 1 comment

Comments

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Nov 11, 2019

To help avoid things like #1019. It'd be nice to automate this (e.g. with a configure script) so that these fields are always populated as appropriate based the version in the DESCRIPTION file.

I don't think we need a full-blown autoconf script; rather, we could just use a simple configure / configure.win script to build e.g. config.h from config.h.in.

If I can toot my own horn, I would propose using configure to make this happen. Note that this would not require any explicit dependency on the configure package; the necessary infrastructure would be bundled into Rcpp itself.

Otherwise, it'd be simple to (say) have configure / configure.win scripts which merely sourced a helper R script that manages the configure process.

Let me know if this sounds worth doing.

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Nov 11, 2019

Allow me to gently vote against. I also maintain maybe a dozen configure.ac across packages, but the one-time release process is different. I have set such things up in the past (e.g. RInside and littler stored a decade ago which SVN revision built the package) but I generally just use one-off scripts.

In this case, a one-off script to modify config.h would have helped. Then again when you look at the git log of that file I didn't miss all that often. So call it a 🤷‍♂️

Edit: I fell on a first pass for your configure not being configure but we both agree. A one-off script could help. I don't think I really need one but I will try to make some time to look into the configure-that-is-not-really-configure to see if it would help my workflow.

eddelbuettel added a commit that referenced this issue Nov 13, 2019
new test for version number consistency (fixes #1021)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.