Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small updates incl hide away parts of #1003 if C++11 not available #1012

Merged
merged 1 commit into from Nov 8, 2019

Conversation

eddelbuettel
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #1012 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files          63       63           
  Lines        3166     3166           
=======================================
  Hits         2611     2611           
  Misses        555      555
Impacted Files Coverage Δ
inst/include/Rcpp/XPtr.h 58.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62be047...6f320f3. Read the comment docs.

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel merged commit c1960c3 into master Nov 8, 2019
@eddelbuettel eddelbuettel deleted the bugfix/xptr_ctor branch November 10, 2019 14:58
eddelbuettel added a commit that referenced this pull request Nov 14, 2019
Small update to XPtr removing C++11 syntax following PR #1012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants