Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small updates incl hide away parts of #1003 if C++11 not available #1012

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@eddelbuettel
Copy link
Member

eddelbuettel commented Nov 7, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #1012 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files          63       63           
  Lines        3166     3166           
=======================================
  Hits         2611     2611           
  Misses        555      555
Impacted Files Coverage Δ
inst/include/Rcpp/XPtr.h 58.33% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62be047...6f320f3. Read the comment docs.

Copy link
Contributor

kevinushey left a comment

LGTM!

@eddelbuettel eddelbuettel merged commit c1960c3 into master Nov 8, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the bugfix/xptr_ctor branch Nov 10, 2019
stephematician pushed a commit to stephematician/Rcpp that referenced this pull request Nov 13, 2019
eddelbuettel added a commit that referenced this pull request Nov 14, 2019
Small update to XPtr removing C++11 syntax following PR #1012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.