Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recommend importFrom in Rcpp FAQ (closes #1030) #1031

Merged
merged 2 commits into from
Dec 5, 2019
Merged

recommend importFrom in Rcpp FAQ (closes #1030) #1031

merged 2 commits into from
Dec 5, 2019

Conversation

eddelbuettel
Copy link
Member

In response to #1030 this adds some language to the FAQ

  • Code compiles correctly
  • R CMD check still passes all tests
  • Document the changes by file in ChangeLog

kevinushey
kevinushey approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel merged commit d0b4106 into master Dec 5, 2019
@kylebaron kylebaron mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinushey kevinushey kevinushey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddelbuettel @kevinushey