Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommend importFrom in Rcpp FAQ (closes #1030) #1031

Merged
merged 2 commits into from Dec 5, 2019

Conversation

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 5, 2019

In response to #1030 this adds some language to the FAQ

  • Code compiles correctly
  • R CMD check still passes all tests
  • Document the changes by file in ChangeLog
@eddelbuettel eddelbuettel requested a review from kevinushey Dec 5, 2019
Copy link
Contributor

@kevinushey kevinushey left a comment

LGTM!

@eddelbuettel eddelbuettel merged commit d0b4106 into master Dec 5, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.