Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more nocov #1036

Merged
merged 4 commits into from Dec 14, 2019
Merged

more nocov #1036

merged 4 commits into from Dec 14, 2019

Conversation

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 14, 2019

Hopefully uncontroversial: just a few // #nocov tags in src/

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Document the changes by file in ChangeLog
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 14, 2019

Codecov Report

Merging #1036 into master will increase coverage by 2.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
+ Coverage      89%   91.92%   +2.91%     
==========================================
  Files          64       64              
  Lines        3038     2935     -103     
==========================================
- Hits         2704     2698       -6     
+ Misses        334      237      -97
Impacted Files Coverage Δ
src/barrier.cpp 100% <ø> (+33.73%) ⬆️
src/attributes.cpp 100% <ø> (+2.07%) ⬆️
src/date.cpp 100% <ø> (+33.88%) ⬆️
src/api.cpp 100% <ø> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6bf21...84dd399. Read the comment docs.

@eddelbuettel eddelbuettel merged commit 43a6d84 into master Dec 14, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the feature/more_nocov branch Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.