define safe variant of short_file_name #1067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for Rcpp
Closes #1066. This PR comes with two pieces:
A "safe" definition of
short_file_name
, defined and used explicitly in theRcpp::debug
namespace;A re-worked version of the "old" (+ registered)
short_file_name
, which now uses a static buffer. I believe the method should be effectively un-used but I figured since it's a registered routine it's best to keep the API the same and just silence the compiler warning.Checklist
R CMD check
still passes all tests