Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upremove erroneous PreserveObject call in String::wrap #1082
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
- Coverage 95.55% 95.54% -0.01%
==========================================
Files 64 64
Lines 2787 2784 -3
==========================================
- Hits 2663 2660 -3
Misses 124 124
|
Part of #1081.
This PR fixes an issue where
String::wrap()would un-necessarily callRcpp_PreserveObject(), thereby 'leaking' the SEXP returned to R (basically, not allowing the R GC to ever collect that object).Unfortunately it doesn't fix #1081 but I do think it's at least part of the issue.
Checklist
R CMD checkstill passes all tests