-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using variadic templates instead of pre-generated code where supported #1303
Changes from all commits
b7fbc35
cf91416
95674df
bde28b5
d81da84
4f69b9e
cd56401
6f0bad1
30d87c9
b698883
49bf0eb
132b846
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,9 @@ | ||
2024-05-23 Andrew Johnson <andrew.johnson@arjohnsonau.com> | ||
|
||
* Added variadic templates to be used instead of the generated code | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This usually starts with a 'where', commonly a single file. Mayne add Dont't sweat over the details, I can clean this up later I just thought I'd point it out before your next PR 😜 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good to know! That's the last of my changes/updates, so feel free to let me know if there are any other things to cleanup here - otherwise I'll wait to hear if I managed to break anything in the reverse-dependency checks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep. Because the (large, careful) PR came in stages and because the rev.dep machine runs slowwwwwwwwwly we are still at stage 2 of 3. I will re-start with the now complete set of changes so it'll be a few days ... but this is looking very very good, and it is both help -- and appreciated! So big thank you! |
||
in `Rcpp/generated` and `Rcpp/module` when compiling with C++11 or | ||
later. | ||
|
||
2024-05-18 Dirk Eddelbuettel <edd@debian.org> | ||
|
||
* docker/ci-4.3/Dockerfile: Add rcpp/ci-4.3 container for R 4.3.* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always two spaces (the small things....)