Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up-pedantic does not like that (`R_xlen_t` vs `size_t) #348
Conversation
`data` is a `std::vector` anyway, so I don't see the point of using `R_xlen_t`.
romainfrancois
added a commit
to tidyverse/dplyr
that referenced
this pull request
Aug 23, 2015
|
Nice catch, thanks. |
eddelbuettel
added a commit
that referenced
this pull request
Aug 23, 2015
-pedantic does not like that (`R_xlen_t` vs `size_t)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
datais astd::vectoranyway, so I don't see the point of usingR_xlen_t.