incorporate @thirdwing's suggestion for sugar ops (closes #392) #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinushey
force-pushed
the
feature/subset-proxy-sugar-math
branch
2 times, most recently
from
14b2402 to
61528c6
Compare
kevinushey
force-pushed
the
feature/subset-proxy-sugar-math
branch
from
61528c6 to
93f6838
Compare
|
Oops -- looks like the implementation actually updates the original object rather than generating a new one with the result! Will update. |
eddelbuettel
added a commit
that referenced
this pull request
Nov 7, 2015
incorporate @thirdwing's suggestion for sugar ops (closes #392)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables e.g.
x[y]+x[z].Should we add other binary operators to the list? (I just grabbed the four main arithmetic ones)