Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporate @thirdwing's suggestion for sugar ops (closes #392) #393

Merged
merged 2 commits into from Nov 7, 2015

Conversation

@kevinushey
Copy link
Contributor

commented Nov 7, 2015

Enables e.g. x[y] + x[z].

Should we add other binary operators to the list? (I just grabbed the four main arithmetic ones)

@kevinushey kevinushey force-pushed the feature/subset-proxy-sugar-math branch 2 times, most recently from 14b2402 to 61528c6 Nov 7, 2015
@kevinushey kevinushey force-pushed the feature/subset-proxy-sugar-math branch from 61528c6 to 93f6838 Nov 7, 2015
@kevinushey

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2015

Oops -- looks like the implementation actually updates the original object rather than generating a new one with the result! Will update.

eddelbuettel added a commit that referenced this pull request Nov 7, 2015
incorporate @thirdwing's suggestion for sugar ops (closes #392)
@eddelbuettel eddelbuettel merged commit be7ba63 into master Nov 7, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the feature/subset-proxy-sugar-math branch Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.