Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #278 by automatically inserting whitespace #400

Merged
merged 1 commit into from
Nov 27, 2015
Merged

Fix #278 by automatically inserting whitespace #400

merged 1 commit into from
Nov 27, 2015

Conversation

kafku
Copy link
Contributor

@kafku kafku commented Nov 14, 2015

fix #278 just by simply converting &foo into & foo.

@eddelbuettel
Copy link
Member

Thanks, we'll take a look. This is fairly deep in @jjallaire 's territory, and he may not get to it on the weekend.

by simply inserting space
@jjallaire
Copy link
Member

I'm going to need to take some time to carefully examine whether this has
the potential to break anything. Don't have time for that right now but
should within the next couple of weeks (also not a great time to take a PR
as we are just about to roll a release).

On Sat, Nov 14, 2015 at 1:14 PM, Dirk Eddelbuettel <notifications@github.com

wrote:

Thanks, we'll take a look. This is fairly deep in @jjallaire
https://github.com/jjallaire 's territory, and he may not get to it on
the weekend.


Reply to this email directly or view it on GitHub
#400 (comment).

@eddelbuettel
Copy link
Member

Actually, the 0.12.2 release is finalized and has been sitting in the incoming queue in Vienna since yesterday morning (when I just seem to have missed a batch of processing).

I would expect it to be on CRAN within a day.

@jjallaire jjallaire merged commit 031d40c into RcppCore:master Nov 27, 2015
@jjallaire
Copy link
Member

Thanks @kafku. Could you send another PR with appropriate ChangeLog and NEWS entries?

@eddelbuettel
Copy link
Member

Or I'll just do it as I often do...

@kafku
Copy link
Contributor Author

kafku commented Nov 27, 2015

Unfortunately, The Japanese, including me, cannot write appropriate English.

@eddelbuettel
Copy link
Member

I am on it :) Typing as I commute.

@kafku
Copy link
Contributor Author

kafku commented Nov 27, 2015

@eddelbuettel
I appreciate it.

eddelbuettel added a commit that referenced this pull request Nov 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when passing arguments by reference
3 participants