Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize base class in the copy constructor #411

Merged
merged 1 commit into from Dec 31, 2015

Conversation

@jpritikin
Copy link
Contributor

@jpritikin jpritikin commented Dec 29, 2015

See issue #410 for background.

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 29, 2015

Looks ok -- I had in the meanwhile looked at #410 and the actual file and wondered if we always had Base around. This makes it clearer.

I'll pull this in manually and run a full reverse depends check on it. If that doesn't throw anything I vote in favor of including this.

eddelbuettel added a commit that referenced this pull request Dec 31, 2015
Initialize base class in the copy constructor
@eddelbuettel eddelbuettel merged commit 29165ca into RcppCore:master Dec 31, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eddelbuettel added a commit that referenced this pull request Jan 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.