Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixing issue with Rcpp::String and Rcpp::Nullable #453
Conversation
|
I see. By setting a few of the member 'later' after having passed some sanity checks, we survive the corner case. Nice. |
|
I would, however, suggest an rdepends check on this one as it messes with some fundamental constructors. |
|
LGTM. Just a remainder, please close the issue when merging. |
|
I'll merge this now and turn on a rev dep check. If it barks we can still revert. |
|
And just for the record the reverse depends worked out just fine. Thanks again for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This addresses #452 in the manner suggested by @thirdwing.
Complete with unit tests.