Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate stop() with NORET #487

Merged
merged 4 commits into from Jun 2, 2016
Merged

Annotate stop() with NORET #487

merged 4 commits into from Jun 2, 2016

Conversation

@krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Jun 1, 2016

per @kevinushey's suggestion. Fixes #486.

Closes #488 (=includes it).

Kirill Müller added 2 commits Jun 1, 2016
Kirill Müller
Kirill Müller
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Jun 2, 2016

I believe this is (once again) an auto-generated file but with the rushed way in which this repo got moved from svn we may have lost the connection to the generator script. It may still be in the rcpp-logs repo.

Can you please add a ChangeLog entry and possibly a line for NEWS.Rd and then I'd be happy to merge.

Kirill Müller added 2 commits Jun 2, 2016
@krlmlr
Copy link
Contributor Author

@krlmlr krlmlr commented Jun 2, 2016

Done. I merged #488 here and added both NEWS entries.

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Jun 2, 2016

Thanks so much, looks great.

@eddelbuettel eddelbuettel merged commit 2a33dcc into RcppCore:master Jun 2, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.