Skip to content

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Jun 1, 2016

Compiling with -pedantic gives me warnings about "long long" otherwise.

@eddelbuettel
Copy link
Member

I was fearful when I saw the subject/title but it looks very much like this does the right thing. Will merge later.

So thanks!

@krlmlr
Copy link
Contributor Author

krlmlr commented Jun 2, 2016

I wonder if we want to minimize the number of #ifdef-s by regrouping.

@eddelbuettel
Copy link
Member

I'd say minimize changes so leave it. But ChangeLog and NEWS.Rd would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants