Skip to content

/ Rcpp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use long long only if available #488

Closed
wants to merge 1 commit into from
Closed

Use long long only if available #488

wants to merge 1 commit into from

Conversation

@krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Jun 1, 2016

Compiling with -pedantic gives me warnings about "long long" otherwise.
Kirill Müller
use long long only if available
Loading status checks…
c3eea4a
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Jun 2, 2016

I was fearful when I saw the subject/title but it looks very much like this does the right thing. Will merge later.

So thanks!
@krlmlr
Copy link
Contributor Author

@krlmlr krlmlr commented Jun 2, 2016

I wonder if we want to minimize the number of #ifdef-s by regrouping.
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Jun 2, 2016

I'd say minimize changes so leave it. But ChangeLog and NEWS.Rd would be nice.
@krlmlr krlmlr mentioned this pull request Jun 2, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@krlmlr @eddelbuettel
You can’t perform that action at this time.