Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upModernize rcppgibbs #532
Merged
Modernize rcppgibbs #532
Conversation
Part of #56's push to switch examples away from the cxxfunction to Rcpp attributes.
|
Looks beautiful and is in a size that is easy to chew and digest. Plan to merge, but will leave it here for the remainder of the day for others to chime in. |
|
Looks good to me as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Part of #56's push to switch examples away from the cxxfunction to Rcpp attributes.
From the discussion of #56, it seems like there will be multiple PRs to complete the job. Specifically, 1 PR per example directory / vignette.