Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange string_elt/vector_elt to accept R_xlen_t #560
Conversation
|
That looks very clean, thumbs up. Will look some more later. I am having issue with Travis right now -- which appears to be down per https://www.traviscistatus.com/. Might be best to just wait a few hours and then resubmit at Travis. |
|
LGTM as well! (Travis is probably down due to http://gizmodo.com/this-is-probably-why-half-the-internet-shut-down-today-1788062835) |
|
Restarted, and passed as expecting. So ... merging. |
|
Aye, that'd be the reason. We've been tracking the outage where I work and On Fri, Oct 21, 2016 at 2:32 PM, Kevin Ushey notifications@github.com
|
As @eddelbuettel suggest, break #556 into some small PRs.
This also makes the Changelog looks better.