Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change string_elt/vector_elt to accept R_xlen_t #560

Merged
merged 1 commit into from Oct 21, 2016

Conversation

@thirdwing
Copy link
Member

@thirdwing thirdwing commented Oct 21, 2016

As @eddelbuettel suggest, break #556 into some small PRs.

This also makes the Changelog looks better.

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Oct 21, 2016

That looks very clean, thumbs up. Will look some more later.

I am having issue with Travis right now -- which appears to be down per https://www.traviscistatus.com/. Might be best to just wait a few hours and then resubmit at Travis.

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Oct 21, 2016

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Oct 21, 2016

Restarted, and passed as expecting. So ... merging.

@eddelbuettel eddelbuettel merged commit 8fc0eab into RcppCore:master Oct 21, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thirdwing thirdwing deleted the thirdwing:iss391_patch1 branch Oct 21, 2016
@hrbrmstr
Copy link

@hrbrmstr hrbrmstr commented Oct 25, 2016

Aye, that'd be the reason. We've been tracking the outage where I work and
watching the various providers try to compensate. Such a fragile internet
we have.

On Fri, Oct 21, 2016 at 2:32 PM, Kevin Ushey notifications@github.com
wrote:

LGTM as well! (Travis is probably down due to http://gizmodo.com/this-is-
probably-why-half-the-internet-shut-down-today-1788062835)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#560 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAfHtvloPiFS3EabzPAPLgEgp_wWwTu0ks5q2QVMgaJpZM4KddXr
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.