This addresses the compiler warning described in #574, which is also present in SelfHash. Unit tests for the sugar function unique are also added.
Fixed signed comparison in IndexHash; unit tests for unique() (closes #…
Avoid GNU extensions in variadic macros
Resolve merge conflict
Sweet. Looks good from a quick (and obviously superficial) glance.
I actually didn't mean for these changes to get lumped into the existing PR, but hopefully it doesn't turn out to be an issue.
I noticed that too. No big deal -- I think you could have avoided it by starting not only from your fork but with the fork from a distinct branch.
LGTM. Although this can be in two separate PR.
I don't think it is worth splitting the PRs. I'll be happy to merge as is. We don't obsess too much over about squashing all PRs into single commits etc pp.
But of course if someone feels strongly enough about it to make all the changes I won't ignore them...