Feature/no sugar tonight in my coffee #585

Merged
merged 7 commits into from Nov 13, 2016

Projects

None yet

3 participants

@dcdillon
Contributor

Fixes #584 by the method detailed in the issue report.

@dcdillon dcdillon referenced this pull request in dcdillon/RcppHoney Nov 12, 2016
Merged

First pass at matrix stuff! #18

@thirdwing
Member

I think we can merge and it will be better if @dcdillon can add some change log.

@dcdillon
Contributor

Modified inst/NEWS.Rd. Hope that's what you meant.

@eddelbuettel
Member

Pretty much every repo has a file ChangeLog. Thought you'd noticed ;-)

@dcdillon
Contributor

Must be blind. I looked! Fixing.

@dcdillon
Contributor

Would it be reasonable to add a 'no_sugar' plugin so this can be turned on easily on a per-source file basis?

@eddelbuettel
Member

Maybe. I don't think I'd have use for it. Why would you turn sugar off, and why can't a #define before #include <Rcpp.h> do it?

@dcdillon
Contributor

Just looks cleaner than arbitrarily sticking #define in your .cpp files. Not a huge issue, just a thought.

I turn sugar off to get better handling of matrix operations without causing ambiguities in operator calls.

@eddelbuettel eddelbuettel merged commit 127f14d into RcppCore:master Nov 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment