New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggested fix for maacheck (closes #685) #686

Merged
merged 1 commit into from Apr 29, 2017

Conversation

Projects
None yet
4 participants
@eddelbuettel
Member

eddelbuettel commented Apr 26, 2017

No description provided.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 26, 2017

Codecov Report

Merging #686 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #686   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          66       66           
  Lines        3511     3511           
=======================================
  Hits         3152     3152           
  Misses        359      359
Impacted Files Coverage Δ
inst/include/Rcpp/exceptions.h 50% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb4d7a...320b03b. Read the comment docs.

Codecov Report

Merging #686 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #686   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          66       66           
  Lines        3511     3511           
=======================================
  Hits         3152     3152           
  Misses        359      359
Impacted Files Coverage Δ
inst/include/Rcpp/exceptions.h 50% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb4d7a...320b03b. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Apr 28, 2017

Member

@kevinushey @nathan-russell @thirdwing @jjallaire -- any comments?

It's the last Rf_mkString and Rf_install interaction remaining.

Member

eddelbuettel commented Apr 28, 2017

@kevinushey @nathan-russell @thirdwing @jjallaire -- any comments?

It's the last Rf_mkString and Rf_install interaction remaining.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Apr 29, 2017

Member

Re-pinging @kevinushey @nathan-russell @thirdwing @jjallaire just in case but will commit unless anybody screams. This should be harmless.

Member

eddelbuettel commented Apr 29, 2017

Re-pinging @kevinushey @nathan-russell @thirdwing @jjallaire just in case but will commit unless anybody screams. This should be harmless.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Apr 29, 2017

Member

Thank you both!

Member

eddelbuettel commented Apr 29, 2017

Thank you both!

@eddelbuettel eddelbuettel merged commit c57b754 into master Apr 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the bugfix/issue685 branch Apr 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment