Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggested fix for maacheck (closes #685) #686

Merged
merged 1 commit into from
Apr 29, 2017
Merged

Conversation

eddelbuettel
Copy link
Member

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #686 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #686   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          66       66           
  Lines        3511     3511           
=======================================
  Hits         3152     3152           
  Misses        359      359
Impacted Files Coverage Δ
inst/include/Rcpp/exceptions.h 50% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feb4d7a...320b03b. Read the comment docs.

@eddelbuettel
Copy link
Member Author

@kevinushey @nathan-russell @thirdwing @jjallaire -- any comments?

It's the last Rf_mkString and Rf_install interaction remaining.

@eddelbuettel
Copy link
Member Author

Re-pinging @kevinushey @nathan-russell @thirdwing @jjallaire just in case but will commit unless anybody screams. This should be harmless.

@eddelbuettel
Copy link
Member Author

Thank you both!

@eddelbuettel eddelbuettel merged commit c57b754 into master Apr 29, 2017
@eddelbuettel eddelbuettel deleted the bugfix/issue685 branch April 29, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants