New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic exception specification (closes #689) #690

Merged
merged 2 commits into from May 9, 2017

Conversation

Projects
None yet
3 participants
@eddelbuettel
Member

eddelbuettel commented May 7, 2017

Two commits in here:

  • the first is narrow and just removes the dynamic exception mechanism as discussed in #689
  • the second looks invasive but just removes a bunch of spaces.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io May 7, 2017

Codecov Report

Merging #690 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          66       66           
  Lines        3511     3511           
=======================================
  Hits         3152     3152           
  Misses        359      359

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe67e8...3727360. Read the comment docs.

Codecov Report

Merging #690 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          66       66           
  Lines        3511     3511           
=======================================
  Hits         3152     3152           
  Misses        359      359

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe67e8...3727360. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel May 9, 2017

Member

Anyone? Shall I just squash it in?

Member

eddelbuettel commented May 9, 2017

Anyone? Shall I just squash it in?

@eddelbuettel eddelbuettel merged commit c536419 into master May 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the bugfix/issue689 branch May 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment