New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce -Wconversion warnings #691

Merged
merged 1 commit into from May 8, 2017

Conversation

Projects
None yet
4 participants
@krlmlr
Contributor

krlmlr commented May 8, 2017

by using size_t instead of int for local variables.

3/n, I'm afraid the PRs after this will be more challenging to review...

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io May 8, 2017

Codecov Report

Merging #691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #691   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          66       66           
  Lines        3511     3511           
=======================================
  Hits         3152     3152           
  Misses        359      359

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe67e8...ac379ca. Read the comment docs.

Codecov Report

Merging #691 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #691   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          66       66           
  Lines        3511     3511           
=======================================
  Hits         3152     3152           
  Misses        359      359

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe67e8...ac379ca. Read the comment docs.

@eddelbuettel

Looks good to me.

But then I am on coffee #1 for the day...

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel May 8, 2017

Member

I'm afraid the PRs after this will be more challenging to review...

Maybe let's discuss them more here on issues or on the list? Or we keep'em in branches and don't immediately PR? Other ideas?

Member

eddelbuettel commented May 8, 2017

I'm afraid the PRs after this will be more challenging to review...

Maybe let's discuss them more here on issues or on the list? Or we keep'em in branches and don't immediately PR? Other ideas?

@krlmlr

This comment has been minimized.

Show comment
Hide comment
@krlmlr

krlmlr May 8, 2017

Contributor

I could do a "for-discussion" PR in my own repo to reduce clutter here.

Contributor

krlmlr commented May 8, 2017

I could do a "for-discussion" PR in my own repo to reduce clutter here.

@kevinushey

This comment has been minimized.

Show comment
Hide comment
@kevinushey

kevinushey May 8, 2017

Contributor

LGTM

Contributor

kevinushey commented May 8, 2017

LGTM

@eddelbuettel eddelbuettel merged commit abea6f2 into RcppCore:master May 8, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel May 11, 2017

Member

@kevinushey @krlmlr when you have a moment, can you check package hBayesDM? Something have changed there in its dependencies, but for Rcpp 0.12.10 (as on CRAN) and our master, my builds (simple R CMD INSTALL) goes crazy and completely hogs my (big-ish) machine at work. I killed the tests by the time the load gets to 30 ...

I don't think it is us. I may just skip the package going forward.

Member

eddelbuettel commented May 11, 2017

@kevinushey @krlmlr when you have a moment, can you check package hBayesDM? Something have changed there in its dependencies, but for Rcpp 0.12.10 (as on CRAN) and our master, my builds (simple R CMD INSTALL) goes crazy and completely hogs my (big-ish) machine at work. I killed the tests by the time the load gets to 30 ...

I don't think it is us. I may just skip the package going forward.

@kevinushey

This comment has been minimized.

Show comment
Hide comment
@kevinushey

kevinushey May 11, 2017

Contributor

This is presumedly with the CRAN version of hBayesDM? I'll see if I can reproduce...

Contributor

kevinushey commented May 11, 2017

This is presumedly with the CRAN version of hBayesDM? I'll see if I can reproduce...

@kevinushey

This comment has been minimized.

Show comment
Hide comment
@kevinushey

kevinushey May 11, 2017

Contributor

I see the same thing on macOS -- clang is just sitting there chomping up CPU and gobbling up more and more memory (at 2.5GB now).

I suspect that whatever the issue is, it's independent of Rcpp.

Contributor

kevinushey commented May 11, 2017

I see the same thing on macOS -- clang is just sitting there chomping up CPU and gobbling up more and more memory (at 2.5GB now).

I suspect that whatever the issue is, it's independent of Rcpp.

@krlmlr krlmlr deleted the krlmlr:f-Wconversion-3 branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment