New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cbegin()/cend() to MatrixRow #750

Merged
merged 3 commits into from Sep 29, 2017

Conversation

Projects
None yet
2 participants
@dcdillon
Contributor

dcdillon commented Sep 18, 2017

Left an upgrade path to proper const-correctness, though through a trick of...something...the MatrixRow::iterator class was already (and still is) a const_iterator.

Anyhow, foundation laid for proper const correctness and there is no issue in adding cbegin() and cend() here as the semantics will be as correct as they've ever been.

@eddelbuettel eddelbuettel merged commit 48b37f6 into RcppCore:master Sep 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment