New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct calls to Rf_warning (closes #776) #777

Merged
merged 1 commit into from Nov 26, 2017

Conversation

Projects
None yet
2 participants
@eddelbuettel
Member

eddelbuettel commented Nov 25, 2017

Quick code reviews would be welcome and appreciated
@coatless @jimhester @kevinushey @nathan-russell

@jimhester

This comment has been minimized.

Contributor

jimhester commented Nov 25, 2017

LGTM, thanks Dirk!

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Nov 25, 2017

Well thanks to you for opening the ticket. It's a good thing to be fixed, so good you stumbled on it in xml2 and sorry it neeeded a change at your end.

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Nov 26, 2017

Passed rev.dep checks, so in it goes.

@eddelbuettel eddelbuettel merged commit 393241c into master Nov 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the bugfix/rcpp_warning branch Nov 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment