Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcorrect calls to Rf_warning (closes #776) #777
Merged
Conversation
|
LGTM, thanks Dirk! |
|
Well thanks to you for opening the ticket. It's a good thing to be fixed, so good you stumbled on it in xml2 and sorry it neeeded a change at your end. |
|
Passed rev.dep checks, so in it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Quick code reviews would be welcome and appreciated
@coatless @jimhester @kevinushey @nathan-russell