Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protect the temporary SEXPs produced by wrap #784

Merged
merged 3 commits into from Dec 6, 2017
Merged

protect the temporary SEXPs produced by wrap #784

merged 3 commits into from Dec 6, 2017

Conversation

kevinushey
Copy link
Contributor

Should resolve #780.

@eddelbuettel
Copy link
Member

Thanks Kevin -- looks very good, will probably merge tomorrow!

@kevinushey
Copy link
Contributor Author

I went through and cleaned up a number of other usages of wrap() -- some of these changes err on the side of caution, but I think it's worth it since the stack-based protection mechanism is quite cheap.

@eddelbuettel
Copy link
Member

@kevinushey I presume you saw but something in the last one upset the unit tests.

@eddelbuettel
Copy link
Member

FYI, full rev dep running, 100 packages in and picture perfect. Will probably merge by tomorrow.

@eddelbuettel eddelbuettel merged commit c3b26f6 into master Dec 6, 2017
@eddelbuettel eddelbuettel deleted the bugfix/proxy-sexp-protection branch December 21, 2017 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange behavior when assigning values in Environment, due to GC
2 participants
@kevinushey @eddelbuettel