Skip to content

/ Rcpp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protect the temporary SEXPs produced by wrap #784

Merged
merged 3 commits into from Dec 6, 2017
Merged

protect the temporary SEXPs produced by wrap #784

merged 3 commits into from Dec 6, 2017

Conversation

@kevinushey
Copy link
Contributor

@kevinushey kevinushey commented Dec 4, 2017

Should resolve #780.
@kevinushey
protect the temporary SEXPs produced by wrap
Loading status checks…
69d2c94
@kevinushey kevinushey force-pushed the bugfix/proxy-sexp-protection branch from b1c0481 to 69d2c94 Dec 4, 2017
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 4, 2017

Thanks Kevin -- looks very good, will probably merge tomorrow!
@kevinushey
clean up some more usages
Loading status checks…
049ecfd
@kevinushey kevinushey force-pushed the bugfix/proxy-sexp-protection branch from 79a6cd5 to 049ecfd Dec 4, 2017
@kevinushey
Copy link
Contributor Author

@kevinushey kevinushey commented Dec 4, 2017

I went through and cleaned up a number of other usages of wrap() -- some of these changes err on the side of caution, but I think it's worth it since the stack-based protection mechanism is quite cheap.
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 4, 2017

@kevinushey I presume you saw but something in the last one upset the unit tests.
@kevinushey
fix tests
Loading status checks…
8670bb6
@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Dec 5, 2017

FYI, full rev dep running, 100 packages in and picture perfect. Will probably merge by tomorrow.
@eddelbuettel eddelbuettel merged commit c3b26f6 into master Dec 6, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the bugfix/proxy-sexp-protection branch Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Strange behavior when assigning values in Environment, due to GC
2 participants
@kevinushey @eddelbuettel
You can’t perform that action at this time.