New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate .Call(...) instead of .Primitive(.Call)(...) for cppFunction #813

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
3 participants
@krlmlr
Contributor

krlmlr commented Feb 14, 2018

Closes #795.

@eddelbuettel eddelbuettel merged commit 72f98ea into RcppCore:master Feb 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Feb 14, 2018

This may become my favourite pull request ever:

R> library(Rcpp)
R> cppFunction("double plusTwo(double x) { return x+2; }")
R> plusTwo
function (x) 
.Call(<pointer: 0x7f692cdf0cb0>, x)
R> plusTwo(40)
[1] 42
R> 

We all just looked at each other assuming the other knew why on earth we used .Primitive() in here too.

@eddelbuettel

This comment has been minimized.

Member

eddelbuettel commented Feb 14, 2018

Well okay, maybe not as famous as the one by @jjallaire that got us Attributes in the first place ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment